[ 
https://issues.apache.org/jira/browse/GORA-432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728095#comment-14728095
 ] 

ASF GitHub Bot commented on GORA-432:
-------------------------------------

GitHub user kamaci opened a pull request:

    https://github.com/apache/gora/pull/34

    GORA-432 Simplify if Statements

    There are some if statements which can be simplified to make code more 
readable.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kamaci/gora GORA-432

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #34
    
----
commit 9c2d225d04cfa746244373fa661a1aa6f03250bb
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-06-27T22:57:51Z

    * JavaPairRDD support for GoraInputFormat.

commit ef68cead273324797cf292dbe6da18ee3fd819cb
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-06-28T14:17:52Z

    * GoraSpark.java initialize method renamed to initializeInput.
    * Architectural change is made.

commit 8fbdef7de963defb1387f0fbbe9e56506b627ba3
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-06-28T15:49:13Z

    * Serialization support via Kyro.

commit 5644a21c5c5678611c7cef4e2c922643088951b8
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-06-28T23:10:26Z

    * map function is implemented as like in LogAnalytics.java

commit 445edb12c35f867e7b81919ddfb509dd8c179ba3
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-06-28T23:26:41Z

    * map was not collecting the counts and it is fixed.

commit 81af4d3afcba4633d0c5d06ead9b4256ea60862f
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-06-29T15:33:38Z

    * GoraSpark.java initializeInput method renamed to initialize
    * reduce part is added to example.

commit 80c0c26d8fb6a9a84ea39f5aa96cc343b4546266
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-06-29T16:26:28Z

    Organizing codes
    Documentation

commit c111e6290fa16d2cc560eb29dbc07eb2f8b7734b
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-07-15T17:23:51Z

    * Writing to Hbase via Spark is implemented.

commit cf6e76585b18ff926f8e7e4928f2d7cd28ac7c6f
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-07-16T16:38:37Z

    * Added dependency to write output to Solr.

commit 219557002f0e33ef6d0e2bb49471d24fb867b0ac
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-17T18:21:43Z

    Code is organized at LogAnalyticsSpark.java.

commit 62be0c312927e3ea4962eb966689b49dc1fcebce
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-17T19:25:12Z

    * GoraSparkEngine.java architecture is improved.

commit 8584911176712f63e316707ace23a12060588cdc
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-17T20:25:15Z

    GoraSparkEngine.java setOutput method renamed to generateOutputConf.
    Added a new method to GoraSparkEngine.java which creates a job and returns 
necessary conf for Spark to use.

commit 92b71a6d2c95492621a56e48470e951e982cc34f
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-17T20:34:40Z

    Unnecessary reuseObjects is removed.

commit 8893fd5c6c53b19925c99668d24df23c52e70b1e
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-21T12:58:21Z

    Unnecessary imports are removed from LogAnalyticsSpark.java

commit 9cff33598231e9cf54060cecf1ccacdf62e64c5b
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-22T13:46:55Z

    Minor improvements for LogAnalyticsSpark.java

commit e817a7f0eeb2efb98937efb92701705ec80891b9
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-22T14:31:57Z

    Spark engine word count tests are implemented.
    Due to a connection problem, spark engine word count tests are ignored.

commit 8f1acc6d4ef6c192e8fc06287558b7bc7c39b040
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-22T19:06:42Z

    Minor change at SparkWordCount.java

commit 888c899f966c27dec1fb173611812f8574737da1
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-27T20:46:34Z

    Spark version should be placed at parent pom and it's done.

commit ad4f5601ebd52e182bf79ba4032dcb85d918b925
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-27T21:15:42Z

    servlet dependency is excluded from spark, not ant. Without excluding it 
throws a java security exception. Motivation for it: 
https://issues.apache.org/jira/browse/SPARK-1693 and

commit 6252eddfecf5a9cba028e1d7529b6dee3ec5ef33
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-27T21:21:31Z

    LogAnalyticsSpark is let to run from command line by passing 
"loganalyticsspark" argument.

commit 3cf550264d782bcffa15fdf62c584eca355cab29
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-08-27T21:57:26Z

    Spark version is changed to 1.4.1 from 1.3.1.

commit 833068d02fc0688dab1083557e16dcc9c7b135f2
Author: Furkan KAMACI <furkankam...@gmail.com>
Date:   2015-09-02T21:48:03Z

    Simplification at if statements.

----


> Simplify if Statements
> ----------------------
>
>                 Key: GORA-432
>                 URL: https://issues.apache.org/jira/browse/GORA-432
>             Project: Apache Gora
>          Issue Type: Improvement
>            Reporter: Furkan KAMACI
>            Priority: Trivial
>
> There are some _if_ statements which can be simplified to make code more 
> readable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to