[ 
https://issues.apache.org/jira/browse/GORA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16063273#comment-16063273
 ] 

ASF GitHub Bot commented on GORA-502:
-------------------------------------

Github user djkevincr commented on a diff in the pull request:

    https://github.com/apache/gora/pull/111#discussion_r124043213
  
    --- Diff: 
gora-aerospike/src/test/java/org/apache/gora/aerospike/GoraAerospikeTestDriver.java
 ---
    @@ -0,0 +1,78 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.gora.aerospike;
    +
    +import org.apache.gora.GoraTestDriver;
    +import org.apache.gora.aerospike.store.AerospikeStore;
    +import org.apache.gora.persistency.Persistent;
    +import org.apache.gora.store.DataStore;
    +import org.apache.gora.store.DataStoreFactory;
    +import org.apache.gora.util.GoraException;
    +import org.testcontainers.containers.GenericContainer;
    +
    +import java.util.Properties;
    +
    +/**
    + * Helper class for third part tests using gora-aerospike backend.
    + * @see GoraTestDriver
    + */
    +public class GoraAerospikeTestDriver extends GoraTestDriver {
    +
    +  private GenericContainer aerospikeContainer;
    --- End diff --
    
    Check whether you can make this test-containers code generic, this can be 
reused for other datastore which doesn't have java based embedded server.


> Implement Aerospike Datastore
> -----------------------------
>
>                 Key: GORA-502
>                 URL: https://issues.apache.org/jira/browse/GORA-502
>             Project: Apache Gora
>          Issue Type: New Feature
>          Components: gora-aerospike, storage
>    Affects Versions: 0.6.1
>            Reporter: Cihad Guzel
>            Assignee: Nishadi Kirielle
>              Labels: gsoc2017
>             Fix For: 0.8
>
>
> Aerospike is a NoSQL database solution for real-time operational 
> applications, delivering predictable performance at scale, superior uptime, 
> and high availability at the lowest TCO compared to first-generation NoSQL 
> and relational databases. It could be nice to support Aerospike as a 
> datastore at Gora. Aerospike uses Apache v2 license for Java client and uses 
> aGPL license for Aerospike Server Community Edition. 
> (http://www.aerospike.com/products/)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to