Github user renato2099 commented on a diff in the pull request:
https://github.com/apache/gora/pull/131#discussion_r174717006
--- Diff: gora-core/src/main/java/org/apache/gora/util/IOUtils.java ---
@@ -611,8 +609,7 @@ public static void writeStringArray(DataOutput out,
String[] arr)
String classKey = dataKey + "._class";
String className = conf.get(classKey);
try {
- T obj = (T) DefaultStringifier.load(conf, dataKey,
ClassLoadingUtils.loadClass(className));
- return obj;
+ return (T) DefaultStringifier.load(conf, dataKey,
ClassLoadingUtils.loadClass(className));
} catch (Exception ex) {
--- End diff --
This should throw a more specific exception. DefaultStringifier.load()
throws an IOException.
And actually this should be aligned to the latest discussion with
@alfonsonishikawa and @nishadi about wrapping exceptions into GoraExceptions.
What is your input on this one guys?
---
