Github user nishadi commented on a diff in the pull request:

    https://github.com/apache/gora/pull/132#discussion_r177727883
  
    --- Diff: 
gora-jcache/src/main/java/org/apache/gora/jcache/query/JCacheResult.java ---
    @@ -82,4 +82,9 @@ protected boolean nextInner() throws IOException {
         return true;
       }
     
    +  @Override
    +  public int size() {
    +    return cacheKeySet.size();
    +  }
    +
    --- End diff --
    
    @carlosrmng It is a good practice if you can avoid empty lines like this :) 
 


---

Reply via email to