alfonsonishikawa commented on a change in pull request #135: Goraexplorer
needed changes
URL: https://github.com/apache/gora/pull/135#discussion_r222506186
##########
File path:
gora-compiler/src/main/velocity/org/apache/gora/compiler/templates/record.vm
##########
@@ -180,6 +180,11 @@ public class ${this.mangle($schema.getName())}#if
($schema.isError()) extends or
return new #if
($schema.getNamespace())$schema.getNamespace().#end${this.mangle($schema.getName())}.Builder(other);
}
+ @Override
Review comment:
A clone method. I used it
[here](https://bitbucket.org/alfonsonishikawa/goraexplorer/src/12f226408e7f9686aa6b5975692edf270b94182e/src/main/java/com/nishilua/goraexplorer/tables/TableEntityServiceImpl.java#lines-121)
because `get()` reuses the instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
