[
https://issues.apache.org/jira/browse/GORA-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801240#comment-16801240
]
Alfonso Nishikawa commented on GORA-411:
----------------------------------------
[~jhnmora000], Hi!
Looks good to me too. Just remember to add the test to
`org.apache.gora.store.DataStoreTestBase` and the code you wrote to
`org.apache.gora.store.DataStoreTestUtil` (maybe this is what you did). I can't
think about any other test.
My +1. Create a pull request with this in github and we will review it :)
> Add exists(key) to DataStore interface
> --------------------------------------
>
> Key: GORA-411
> URL: https://issues.apache.org/jira/browse/GORA-411
> Project: Apache Gora
> Issue Type: Improvement
> Components: gora-core, storage
> Reporter: Alfonso Nishikawa
> Priority: Minor
> Fix For: 0.9
>
>
> NUTCH-1679 need to check if there exists some rows and they are proposing to
> use {{store.get(TableUtil.reverseUrl(url)))}}.
> This will have a considerably impact on performance since every column will
> be fetched.
> Some datastores implements a call to just check if a row exists (like HBase)
> so no data is transfered by network.
> If a datastore can't handle an "exists" call, can default to a get.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
