djkevincr commented on a change in pull request #158: GORA-555: Improve Lucene
query implementation with NumericRangeQuery
URL: https://github.com/apache/gora/pull/158#discussion_r272787234
##########
File path:
gora-lucene/src/test/java/org/apache/gora/lucene/store/TestLuceneStore.java
##########
@@ -18,32 +18,40 @@
package org.apache.gora.lucene.store;
import org.apache.gora.examples.WebPageDataCreator;
+import static org.apache.gora.examples.WebPageDataCreator.SORTED_URLS;
+import static org.apache.gora.examples.WebPageDataCreator.URLS;
import org.apache.gora.examples.generated.WebPage;
import org.apache.gora.query.Query;
+import org.apache.gora.query.Result;
import org.apache.gora.store.DataStore;
import org.apache.gora.store.DataStoreTestBase;
+import static org.apache.gora.store.DataStoreTestBase.log;
import org.apache.gora.store.DataStoreTestUtil;
+import org.apache.gora.util.GoraException;
import org.apache.gora.util.OperationNotSupportedException;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Ignore;
import org.junit.Test;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-import static org.apache.gora.examples.WebPageDataCreator.SORTED_URLS;
-import static org.apache.gora.examples.WebPageDataCreator.URLS;
-
-import static org.junit.Assert.assertNotNull;
-import static org.junit.Assert.assertNull;
-import static org.junit.Assert.assertEquals;
-
-
/**
- * TestLuceneStore class executes tests for {@link
org.apache.gora.lucene.store.LuceneStore}
+ * TestLuceneStore class executes tests for
+ * {@link org.apache.gora.lucene.store.LuceneStore}
*/
public class TestLuceneStore extends DataStoreTestBase {
private static final Logger LOG =
LoggerFactory.getLogger(DataStoreTestUtil.class);
+ private DataStore<Integer, EmployeeInt> employeeIntStore;
+
+ @Before
Review comment:
@Before - means this config() method is executed for each tests. Do we
really need that behavior? It is only required to be executed before -
testInferDataType() test case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
