djkevincr commented on issue #161: GORA-565: Enable Spark in Unit Tests URL: https://github.com/apache/gora/pull/161#issuecomment-487832799 @sneceesay77 I have locally tested your PR and ran into some issues. ``` # Don't override properties coming from Hadoop configuration for test # Those properties will contains override for Mongo server port gora.mongodb.override_hadoop_configuration=true ``` I noticed you have made the following property change and due to this, Apache Flink word count test is failing in mongo-db module. As I can see from the log traces, while running Flink jobs it fails to connect to the Mongo server running on the correct port. Basically we should not override the mongo server port which is set to Hadoop conf ( conf.set(MongoStoreParameters.PROP_MONGO_SERVERS, "127.0.0.1:" + port); ) in GoraMongodbTestDriver from the port added in the property file. ( Value in Hadoop conf should have the priority ) Can you please check on this?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
