cuent commented on a change in pull request #177: [GORA-527] Implement a data store for redis URL: https://github.com/apache/gora/pull/177#discussion_r312712034
########## File path: gora-redis/src/test/java/org/apache/gora/redis/GoraRedisTestDriver.java ########## @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.gora.redis; + +import java.io.IOException; +import java.time.Duration; +import org.apache.gora.GoraTestDriver; +import org.apache.gora.redis.store.RedisStore; +import org.apache.gora.redis.util.RedisStartupLogWaitStrategy; +import org.apache.gora.redis.util.ServerMode; +import org.apache.gora.redis.util.StorageMode; +import org.testcontainers.containers.FixedHostPortGenericContainer; + +/** + * Helper class to execute tests in a embedded instance of Redis. + * + * @author Xavier Sumba + */ +public class GoraRedisTestDriver extends GoraTestDriver { + + private static final String DOCKER_CONTAINER_NAME = "grokzen/redis-cluster:latest"; + private FixedHostPortGenericContainer redisContainer = ((FixedHostPortGenericContainer) new FixedHostPortGenericContainer(DOCKER_CONTAINER_NAME) + .waitingFor(new RedisStartupLogWaitStrategy()) + .withStartupTimeout(Duration.ofMinutes(3)) + .withEnv("STANDALONE", "true") + .withEnv("SENTINEL", "true")) Review comment: Unfortunately, port configuration for masters and slaves into the container is static. So, if we do a forward from a port to a random, this reference will be lost, and as a consequence, the connection won't be possible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
