djkevincr commented on a change in pull request #175: GORA-546 Hazelcast Jet execution engine support URL: https://github.com/apache/gora/pull/175#discussion_r316594560
########## File path: pom.xml ########## @@ -792,6 +792,7 @@ <module>gora-ignite</module> <module>gora-tutorial</module> <module>sources-dist</module> + <module>gora-jet</module> Review comment: You need to move gora-jet module before sources-dist module. Otherwise jet module will not be packaged into source distribution. Ideally it should be built even before gora-tutorial, since we have dependency to gora-jet from gora-tutorial. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services