alfonsonishikawa commented on a change in pull request #227:
URL: https://github.com/apache/gora/pull/227#discussion_r513724584



##########
File path: gora-lucene/src/test/conf/gora-lucene-mapping.xml
##########
@@ -16,7 +16,8 @@
    limitations under the License.
 -->
 
-<gora-otd>
+<gora-otd xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
+          xsi:noNamespaceSchemaLocation="gora-lucene.xsd">

Review comment:
       What does "noNamespaceSchemaLocation" means? Is that the default 
namespace? Do <class> and <primarykey> use that by default?
   I suggest to create a Unit Test to check that an ill-formed mapping does not 
pass the validation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to