Hi, Thank you for your feedback.
Yes, I did not check that XSD validation was working. I will fix it and also add a test for it. I will add comments for the connection parameters. Yes, it seems you are right that Docker container has no authentication parameters, because I did not set them up. I will look into it too. Regards, Maria On Thu, 7 Jan 2021 at 05:15, John Mora <jhnmora...@gmail.com> wrote: > Hi, > > Thanks for your hard work. > > Some comments: > > The XSD validation is not working: > > org.apache.gora.util.GoraException: java.lang.RuntimeException: > org.xml.sax.SAXParseException; schema_reference.4: Failed to read schema > document 'file:/tmp/gora/gora-elasticsearch/gora-elasticsearch.xsd', > because 1) could not find the document; 2)... > > The XSD file should be located in the main source code instead of the > tests, you can also add a test for the XSD validation. > > > https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/test/resources/gora-elasticsearch.xsd > > Please add some comments with information about the connection parameters > > > https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/main/java/org/apache/gora/elasticsearch/utils/ElasticsearchParameters.java#L29 > > I think the security is not set up in the Docker container and the > parameters gora.datastore.elasticsearch.username and > gora.datastore.elasticsearch.password are simply ignored by the > Elasticsearch server. Is that right? > > > https://github.com/podorvanova/gora/blob/gora-664/gora-elasticsearch/src/test/java/org/apache/gora/elasticsearch/GoraElasticsearchTestDriver.java > > Cheers, > John > > El sáb, 2 ene 2021 a las 4:52, Maria Podorvanova (< > podorvanova.ma...@gmail.com>) escribió: > >> Hi, >> >> Report #5 >> Period: December 27 - January 2 >> Activities: >> - Added a property for choosing the authentication method [1] >> - Implemented testing with Elasticsearch container [2] >> >> 1. Researched testing side >> 2. Added test dependencies >> 3. Added GoraElasticsearchTestDriver with Elasticsearch container >> 4. Added javadoc descriptions to GoraElasticsearchTestDriver class >> 5. Fixed two existing tests in accordance to Elasticsearch container >> >> - Implement some methods for schema management [3] >> >> 1. schemaExists >> 2. createSchema >> 3. deleteSchema >> 4. flush >> >> >> Here are links to the commits: >> [1] >> https://github.com/apache/gora/commit/457f57a2391856e6d6a5d67c2668c6f28348d40d >> >> [2] >> https://github.com/apache/gora/commit/3d0784721fc8bf158522a6b5dc6e309aae27a2de >> >> [3] >> https://github.com/apache/gora/commit/57da5033ac26a2b31046c83bdfe8729b1aeb6889 >> >> >> Regards, >> Maria >> >
