[
https://issues.apache.org/jira/browse/GORA-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344716#comment-17344716
]
ASF GitHub Bot commented on GORA-656:
-------------------------------------
kamaci commented on a change in pull request #222:
URL: https://github.com/apache/gora/pull/222#discussion_r632663594
##########
File path:
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/store/HazelcastCacheLoaderFactory.java
##########
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.gora.util.GoraException;
+import org.apache.hadoop.conf.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.cache.configuration.Factory;
+
+/**
+ * {@link HazelcastCacheLoaderFactory} is the primary class
+ * responsible for creating cache loader {@link
javax.cache.integration.CacheLoader} instances which itself
+ * loads data beans from persistency dataStore to in memory cache.
+ */
+public class HazelcastCacheLoaderFactory<K, T extends PersistentBase>
+ implements Factory<HazelcastCacheLoader<K, T>> {
+
+ public static final long serialVersionUID = 201305101626L;
+ private static final Logger LOG =
LoggerFactory.getLogger(HazelcastCacheLoaderFactory.class);
+ private transient HazelcastCacheLoader<K, T> instance;
+ private Class<K> keyClass;
+ private Class<T> persistentClass;
+
+ public HazelcastCacheLoaderFactory(HazelcastCacheLoader<K, T> instance,
+ Class<K> keyClass,
+ Class<T> persistentClass) {
+ this.keyClass = keyClass;
+ this.persistentClass = persistentClass;
+ LOG.info("JCache cache entry loader factory initialized successfully.");
+ this.instance = instance;
+ }
+
+ public HazelcastCacheLoader<K, T> create() {
+ if (this.instance != null) {
+ return (HazelcastCacheLoader<K, T>) this.instance;
+ } else {
Review comment:
No need to write `else` after an `if` with a `return`.
##########
File path:
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/store/HazelcastCacheLoaderFactory.java
##########
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.gora.util.GoraException;
+import org.apache.hadoop.conf.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.cache.configuration.Factory;
+
+/**
+ * {@link HazelcastCacheLoaderFactory} is the primary class
+ * responsible for creating cache loader {@link
javax.cache.integration.CacheLoader} instances which itself
+ * loads data beans from persistency dataStore to in memory cache.
+ */
+public class HazelcastCacheLoaderFactory<K, T extends PersistentBase>
+ implements Factory<HazelcastCacheLoader<K, T>> {
+
+ public static final long serialVersionUID = 201305101626L;
+ private static final Logger LOG =
LoggerFactory.getLogger(HazelcastCacheLoaderFactory.class);
+ private transient HazelcastCacheLoader<K, T> instance;
+ private Class<K> keyClass;
+ private Class<T> persistentClass;
+
+ public HazelcastCacheLoaderFactory(HazelcastCacheLoader<K, T> instance,
+ Class<K> keyClass,
+ Class<T> persistentClass) {
+ this.keyClass = keyClass;
+ this.persistentClass = persistentClass;
+ LOG.info("JCache cache entry loader factory initialized successfully.");
+ this.instance = instance;
+ }
+
+ public HazelcastCacheLoader<K, T> create() {
+ if (this.instance != null) {
+ return (HazelcastCacheLoader<K, T>) this.instance;
+ } else {
+ try {
+ this.instance = new HazelcastCacheLoader<>(DataStoreFactory
+ .getDataStore(keyClass, persistentClass, new Configuration()));
+ } catch (GoraException ex) {
+ LOG.error("Couldn't initialize persistent dataStore for cache
loader.", ex);
+ return null;
+ }
+ return (HazelcastCacheLoader<K, T>) this.instance;
+ }
+ }
+
+ public boolean equals(Object other) {
+ if (this == other) {
+ return true;
+ } else if (other != null && this.getClass() == other.getClass()) {
Review comment:
No need to write `else` after an `if` with a `return`.
##########
File path:
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/store/HazelcastCacheWriterFactory.java
##########
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.gora.util.GoraException;
+import org.apache.hadoop.conf.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.cache.configuration.Factory;
+
+/**
+ * {@link HazelcastCacheWriterFactory} is the primary class
+ * responsible for creating cache writer {@link
javax.cache.integration.CacheWriter} instances which itself
+ * writes data beans to persistency dataStore from in memory cache.
+ */
+public class HazelcastCacheWriterFactory<K, T extends PersistentBase>
implements Factory<HazelcastCacheWriter<K, T>> {
+
+ public static final long serialVersionUID = 201205101621L;
+ private static final Logger LOG =
LoggerFactory.getLogger(HazelcastCacheWriterFactory.class);
+ private transient HazelcastCacheWriter<K, T> instance;
+ private Class<K> keyClass;
+ private Class<T> persistentClass;
+
+ public HazelcastCacheWriterFactory(HazelcastCacheWriter<K, T> instance,
+ Class<K> keyClass,
+ Class<T> persistentClass) {
+ this.keyClass = keyClass;
+ this.persistentClass = persistentClass;
+ LOG.info("JCache cache writer factory initialized successfully.");
+ this.instance = instance;
+ }
+
+ public HazelcastCacheWriter<K, T> create() {
+ if (this.instance != null) {
+ return (HazelcastCacheWriter<K, T>) this.instance;
+ } else {
Review comment:
No need to write `else` after an `if` with a `return`.
##########
File path:
gora-hazelcast/src/main/java/org/apache/gora/hazelcast/store/HazelcastCacheWriterFactory.java
##########
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gora.hazelcast.store;
+
+import org.apache.gora.persistency.impl.PersistentBase;
+import org.apache.gora.store.DataStoreFactory;
+import org.apache.gora.util.GoraException;
+import org.apache.hadoop.conf.Configuration;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import javax.cache.configuration.Factory;
+
+/**
+ * {@link HazelcastCacheWriterFactory} is the primary class
+ * responsible for creating cache writer {@link
javax.cache.integration.CacheWriter} instances which itself
+ * writes data beans to persistency dataStore from in memory cache.
+ */
+public class HazelcastCacheWriterFactory<K, T extends PersistentBase>
implements Factory<HazelcastCacheWriter<K, T>> {
+
+ public static final long serialVersionUID = 201205101621L;
+ private static final Logger LOG =
LoggerFactory.getLogger(HazelcastCacheWriterFactory.class);
+ private transient HazelcastCacheWriter<K, T> instance;
+ private Class<K> keyClass;
+ private Class<T> persistentClass;
+
+ public HazelcastCacheWriterFactory(HazelcastCacheWriter<K, T> instance,
+ Class<K> keyClass,
+ Class<T> persistentClass) {
+ this.keyClass = keyClass;
+ this.persistentClass = persistentClass;
+ LOG.info("JCache cache writer factory initialized successfully.");
+ this.instance = instance;
+ }
+
+ public HazelcastCacheWriter<K, T> create() {
+ if (this.instance != null) {
+ return (HazelcastCacheWriter<K, T>) this.instance;
+ } else {
+ try {
+ this.instance = new HazelcastCacheWriter<>(DataStoreFactory
+ .getDataStore(keyClass, persistentClass, new Configuration()));
+ } catch (GoraException ex) {
+ LOG.error("Couldn't initialize persistent dataStore for cache
writer.", ex);
+ return null;
+ }
+ return (HazelcastCacheWriter<K, T>) this.instance;
+ }
+ }
+
+ public boolean equals(Object other) {
+ if (this == other) {
+ return true;
+ } else if (other != null && this.getClass() == other.getClass()) {
Review comment:
No need to write `else` after an `if` with a `return`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Hazelcast IMap backed datastore
> -------------------------------
>
> Key: GORA-656
> URL: https://issues.apache.org/jira/browse/GORA-656
> Project: Apache Gora
> Issue Type: Improvement
> Reporter: Kevin Ratnasekera
> Priority: Major
> Labels: gsoc2020
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Current implementation of JCache datastore is written in a way that it will
> work with any JCache provider. Even though we have made explicitly available
> Hazelcast JCache provider to the classpath. This implementation should be
> based on the native interfaces of IMap.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
