[
https://issues.apache.org/jira/browse/GORA-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17344772#comment-17344772
]
ASF GitHub Bot commented on GORA-651:
-------------------------------------
kamaci commented on a change in pull request #210:
URL: https://github.com/apache/gora/pull/210#discussion_r632680001
##########
File path:
gora-orientdb/src/main/java/org/apache/gora/orientdb/store/OrientDBStore.java
##########
@@ -103,20 +109,36 @@ public void initialize(Class<K> keyClass, Class<T>
persistentClass, Properties p
ROOT_URL =
"remote:".concat(orientDbStoreParams.getServerHost()).concat(":")
.concat(orientDbStoreParams.getServerPort());
ROOT_DATABASE_URL =
ROOT_URL.concat("/").concat(orientDbStoreParams.getDatabaseName());
- remoteServerAdmin = new
OServerAdmin(ROOT_URL).connect(orientDbStoreParams.getUserName(),
- orientDbStoreParams.getUserPassword());
- if
(!remoteServerAdmin.existsDatabase(orientDbStoreParams.getDatabaseName(),
"memory")) {
-
remoteServerAdmin.createDatabase(orientDbStoreParams.getDatabaseName(),
"document", "memory");
- }
-
- if (orientDbStoreParams.getConnectionPoolSize() != null) {
- int connPoolSize =
Integer.valueOf(orientDbStoreParams.getConnectionPoolSize());
- connectionPool = new OPartitionedDatabasePoolFactory(connPoolSize)
- .get(ROOT_DATABASE_URL, orientDbStoreParams.getUserName(),
- orientDbStoreParams.getUserPassword());
+ remoteServerAdmin = new OrientDB(ROOT_URL,
orientDbStoreParams.getUserName(),
+ orientDbStoreParams.getUserPassword(),
OrientDBConfig.defaultConfig());
+ if (!remoteServerAdmin.exists(orientDbStoreParams.getDatabaseName())) {
+ remoteServerAdmin.create(orientDbStoreParams.getDatabaseName(),
+
ODatabaseType.valueOf(orientDbStoreParams.getStorageType().toUpperCase()));
Review comment:
Please pass `Locale.ENGLISH` to `toUpperCase`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade OrientDB to the latest version 3
> ----------------------------------------
>
> Key: GORA-651
> URL: https://issues.apache.org/jira/browse/GORA-651
> Project: Apache Gora
> Issue Type: Improvement
> Reporter: Kevin Ratnasekera
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It seem version 3 based releases [1] have been there for a while, we should
> upgrade from 2.2.22.
> [1] https://orientdb.com/releases/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
