+1 (binding)
Looks good to me.
* sigs/xsums OK
* mvn apache-rat:check passes
* DISCLAIMER present
* L&N look OK
* Dependencies look OK
* Could run tests (yay)
* Generated jar contains L&N
A couple of minor things to fix (nit-picky things -- not release issues)
* Move keys/ to src/test/resources. They appear to be test-related.
Maybe I'll just put a PR in for this one :)
* Maybe slap a header on the eclipse-template.xml. Would be nice, but
not super critical.
Great work, Edward.
Edward Capriolo wrote:
I am pleased to be calling this vote for the source release of Apache
Gossip 0.1.2.
A detailed description of the release is here:
https://lists.apache.org/thread.html/d244f03eba775c0de96bf527c67dce80e393c7ed614d43650cb23793@%3Cdev.gossip.apache.org%3E
Ancillary artifacts such as poms, jars, ect. can be found here:
https://repository.apache.org/content/repositories/orgapachegossip-1003/
The Git commit ID is:
d5fe9f96c8edae620f7b7568c7498486df216806
https://github.com/apache/incubator-gossip/commit/d5fe9f96c8edae620f7b7568c7498486df216806
The tag is:
https://github.com/apache/incubator-gossip/tree/gossip-0.1.2-incubating-b-rc1
Checksums of:
https://repository.apache.org/content/repositories/orgapachegossip-1003/org/apache/gossip/gossip/0.1.2-incubating/gossip-0.1.2-incubating-source-release.zip
SHA1: 5bbb5f097b9f8d0e6812a8d5c875d2fa190c40ff
MD5: 7d6d886bfcdf741530ecc29a0cbfb434
Release artifacts are signed with the following key:
http://people.apache.org/~ecapriolo/
http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
KEYS file available here:
https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS
The artifacts are also staged in
https://dist.apache.org/repos/dist/dev/incubator/gossip/gossip-0.1.2-incubating-rc1/
Please download the release candidate and evaluate the necessary items
including checking hashes, signatures, build from source, and test.
Release this package?
[ ] +1 yes
[ ] +0 no opinion
[ ] -1 Do not release this package because because...
