Hello Edward, I updated the PR based on your review.
I didn’t understand what you meant. You mean all the CRDT tickets under GSoC are assigned for someone or ticket that I tried to fix? Thanks. *Mirage Abeysekara* Undergraduate Computer Science and Engineering University of Moratuwa Twitter: https://twitter.com/MiRAGECreator GooglePlus: https://plus.google.com/u/0/+MirageAbeysekara On 8 March 2017 at 21:30, Edward Capriolo <[email protected]> wrote: > Mirage, > > Also something important to note: Please try to not to work on any more > tickets labeled GSOC yet. We already have someone interested in doing GSOC > (with gossip) and we sized that work so there would be substantial work for > that one person to do during the GSOC period. We need to slice off more > work likely if we end up with two GSOC applicants. > > Thanks > > On Wed, Mar 8, 2017 at 8:29 AM, Edward Capriolo <[email protected]> > wrote: > > > > > > > On Wed, Mar 8, 2017 at 12:01 AM, Mirage Abeysekara < > > [email protected]> wrote: > > > >> Hi all, > >> > >> I'm Mirage Abeysekara, a final year Computer Science and Engineering > >> undergraduate from University of Moratuwa, Sri Lanka. I am interested in > >> contributing to the Apache Gossip by adding CRDT implementations. As a > >> start, I implemented the sample grow-only counter (GOSSIP-63)[1] by > >> refering the Wikipedia[2]. I created a PR for git mirror[3]. It would be > >> great if you can give me some feedback regarding the G-Counter > >> implementation. > >> > >> [1] https://issues.apache.org/jira/browse/GOSSIP-63 > >> [2] > >> https://en.wikipedia.org/wiki/Conflict-free_replicated_data_ > >> type#State-based_increment-only_counter > >> [3] https://github.com/apache/incubator-gossip/pull/41 > >> <https://github.com/apache/incubator-gossip/pull/41> > >> > >> Thanks. > >> > >> *Mirage Abeysekara* > >> Undergraduate > >> Computer Science and Engineering > >> University of Moratuwa > >> Twitter: https://twitter.com/MiRAGECreator > >> GooglePlus: https://plus.google.com/u/0/+MirageAbeysekara > >> > > > > Hello Mirage, > > > > Thank you for the addition. Welcome! I have already done a first pass > > review for you on the g-counter work. > > > > We have set aside some of these tickets for Maxim (another GSOC > > contributor). Make sure you have done what you need to do on your end for > > GSOC. I also filled out a mentor request yesterday and we have to find a > > mentor for you. > > > > Thanks again, > > Edward > > >
