[
https://issues.apache.org/jira/browse/GOSSIP-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268473#comment-16268473
]
ASF GitHub Bot commented on GOSSIP-84:
--------------------------------------
GitHub user catchsudheera opened a pull request:
https://github.com/apache/incubator-gossip/pull/72
Fixing GOSSIP-84 : Consistently use Clock or System for time across the
whole project.
Use of Clock instead of calling System.currentTimeMillis() or
System.nanoTime() to keep consistency as suggested by ticket :
https://issues.apache.org/jira/browse/GOSSIP-84
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/catchsudheera/incubator-gossip master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-gossip/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
commit 7eb294f7dbef69d34c7b0ee3a35e093c4d29e25f
Author: Sudheera Palihakkara <[email protected]>
Date: 2017-11-28T09:47:33Z
Fixing GOSSIP-84 : Consistently use Clock or System for time across the
whole project.
----
> Consistently use Clock or System for time.
> ------------------------------------------
>
> Key: GOSSIP-84
> URL: https://issues.apache.org/jira/browse/GOSSIP-84
> Project: Gossip
> Issue Type: Bug
> Reporter: Gary Dusbabek
> Assignee: RAJKUMAR NATARAJAN
>
> I see a number of cases where System.currentTimeMillis() or System.nanoTime()
> are used for getting ticks. But there is also a Clock instance that is
> clearly used in other cases.
> We should consistently use one or the other. My vote is for Clock.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
