Hi Adam,

I'm excited that we will get your transformer stuff into 0.5. I have applied the transformers also to the SettingsConverter.

The name ModuleDescriptorContributor doesn't fit any longer. We could go for something like: IvyObjectConfigurer. But I'm wondering if it wouldn't be best to give it a truly general name like: TransformableContributor

One other thing is the behavior of the addIvyTransformer(Closure transformer) method. Right now the closure is executed and we pass the transformable as an argument. In code this would look like:

addIvyTransformer { moduleDescriptor ->
   moduleDescriptor.doThis()
   moduleDescriptor.doThat()
}

What about passing no argument to the closure but setting the delegate of the closure to the transformable (like we do it for example in DefaultProject.allprojects)

addIvyTransformer {
   doThis()
   doThat()
}

- Hans

--
Hans Dockter
Gradle Project lead
http://www.gradle.org





---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to