John Murph wrote:
The changes are on my github account
(git://github.com/jmurph/gradle.git
<http://github.com/jmurph/gradle.git>) in branch test_listener. Adam,
would you mind looking at it and giving feedback?
This looks really good. Some comments:
- TestListener: can we get rid of the distinction between an error and a
failure, and just have failures?
- AbstractTestTask: I think we shouldn't make the broadcaster public, as
this is really an internal concern. Perhaps we should also add
addTestListener() and removeTestListener() methods on AbstractTestTask,
plus some javadoc.
- TestNGListenerAdapter: returns a status of FAILURE when a test
failure, but the exception is made available via getError() rather than
getFailure().
- Maybe update the javadoc for Gradle.addListener() to mention that
TestListener is available?
- I'd really like to see an integration test or tests which cover this,
as it seems like something that might be easy to break. Perhaps we could
grow the existing junit and testng int tests, so that we get some
coverage with failing and passing tests.
--
Adam Murdoch
Gradle Developer
http://www.gradle.org
