On 20/07/2011, at 10:10 AM, Luke Daley wrote:

> Hi Adam,
> 
> Could you please give a very brief explanation on the benefits of this change 
> WRT to the gradleApi classpath. I'm just looking to understand it.

The benefit is that we don't duplicate the dependency information for the core 
and coreImpl projects in the code. Instead, we reuse the dependency information 
from the build, in the form of a generated resource. Strategically, it's 
another small step in chopping up the core, as the code that sets up the 
classpaths needs to know less about the implementation now.

The trigger for this was having to change the hardcoded list to include the 
wharf jars.


> 
> Begin forwarded message:
> 
>> From: [email protected]
>> Date: 20 July 2011 7:59:35 AM AEST
>> To: [email protected]
>> Subject: [gradle-scm] [gradle/gradle] 0e964c: - Don't hardcode the stuff 
>> needed for dependencies...
>> Reply-To: [email protected]
>> 
>> Branch: refs/heads/master
>> Home:   https://github.com/gradle/gradle
>> 
>> Commit: 0e964c3fb723733452a0f2d86d937a323a798f86
>>     
>> https://github.com/gradle/gradle/commit/0e964c3fb723733452a0f2d86d937a323a798f86
>> Author: adammurdoch <[email protected]>
>> Date:   2011-07-19 (Tue, 19 Jul 2011)
>> 
>> Changed paths:
>>   M build.gradle
>> A gradle/groovyProject.gradle
>> M subprojects/core/core.gradle
>> M 
>> subprojects/core/src/main/groovy/org/gradle/api/internal/AbstractClassPathProvider.java
>> M 
>> subprojects/core/src/main/groovy/org/gradle/api/internal/DefaultClassPathProvider.java
>> A 
>> subprojects/core/src/main/groovy/org/gradle/api/internal/DependencyClassPathProvider.java
>> M 
>> subprojects/core/src/main/groovy/org/gradle/api/internal/project/GlobalServicesRegistry.java
>> M 
>> subprojects/core/src/main/groovy/org/gradle/api/internal/project/TopLevelBuildServiceRegistry.java
>> M 
>> subprojects/core/src/main/groovy/org/gradle/process/internal/child/WorkerProcessClassPathProvider.java
>> M 
>> subprojects/core/src/main/groovy/org/gradle/testfixtures/internal/GlobalTestServices.java
>> A 
>> subprojects/core/src/test/groovy/org/gradle/api/internal/DependencyClassPathProviderTest.groovy
>> M 
>> subprojects/core/src/test/groovy/org/gradle/api/internal/project/DefaultIsolatedAntBuilderTest.groovy
>> M 
>> subprojects/core/src/test/groovy/org/gradle/api/internal/project/GlobalServicesRegistryTest.java
>> M 
>> subprojects/core/src/test/groovy/org/gradle/api/internal/project/TopLevelBuildServiceRegistryTest.java
>> M subprojects/plugins/plugins.gradle
>> M subprojects/wrapper/wrapper.gradle
>> 
>> Log Message:
>> -----------
>> - Don't hardcode the stuff needed for dependencies.gradleApi(), instead 
>> generate a resource at build time from configurations.runtime. Left the 
>> otehr classpaths alone for now.
>> - Cleaned up the worker process classpath.
>> - Extracted gradle/groovyProject.gradle out of root build.gradle
>> 
>> 
>> 
>> <hr/>
>> <p>
>> To unsubscribe from this list please visit:
>> </p>
>> <p>
>>   <a 
>> href="http://xircles.codehaus.org/manage_email";>http://xircles.codehaus.org/manage_email</a>
>> 
> 
> -- 
> Luke Daley
> Principal Engineer, Gradleware 
> http://gradleware.com
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
> 
>    http://xircles.codehaus.org/manage_email
> 
> 


--
Adam Murdoch
Gradle Co-founder
http://www.gradle.org
VP of Engineering, Gradleware Inc. - Gradle Training, Support, Consulting
http://www.gradleware.com

Reply via email to