I would think that would be part of the plugin. Should the codeQuality task should hang off of the check task, rather than the having the individual checkstyle and codenarc tasks hanging off of there? Would there be benefit in having scoped codeQuality tasks for the different source sets (still with the parent codeQuality task for all of them)? i.e. codeQualityMain, codeQualityTest, etc.
The code-quality plugin name seems a little unfortunate given it is currently scoped directly towards supporting two tools: CodeNarc and Checkstyle. With the possibility of additional quality tools being added (see my Findbugs, PMD, JDepend pull request<https://github.com/gradle/gradle/pull/51>), it would be nice for there to be wider support for integrating additional tools. The simplest option would be to create a new interface (maybe a sub of VerificationTask) perhaps called QualityTask, that all of these could use. Then the codeQuality task could more generically depend on any QualityTask. Other options would be to either have all quality tools supported by their own plugins (implying the breaking down of the code-quality plugin into checkstyle and codenarc plugins) or to have the code-quality plugin support all of the tools built in to Gradle. That would require some method of specifying which tools you want to be run on your project. A related goal would be for all quality plugins to provide both HTML and XML reports. I don't know if this is easily possible for all of the tools, but it would be helpful to have both human readable and CI-server readable results for everything (as with JUnit). Andrew Oberstar On Sun, Nov 27, 2011 at 1:44 PM, Adam Murdoch <[email protected]>wrote: > > Should we add this to the plugin, instead? > > > On 25/11/2011, at 11:55 PM, [email protected] wrote: > > Branch: refs/heads/master > Home: https://github.com/gradle/gradle > > Commit: 397102d9c9be02d806c94cf2c6cda9be8d14883f > > https://github.com/gradle/gradle/commit/397102d9c9be02d806c94cf2c6cda9be8d14883f > Author: Luke Daley <[email protected]> > Date: 2011-11-25 (Fri, 25 Nov 2011) > > Changed paths: > M gradle/codeQuality.gradle > > Log Message: > ----------- > Add “codeQuality” task to projects that runs all codenarc and check style > rules. > > > > <hr/> > <p> > To unsubscribe from this list please visit: > </p> > <p> > <a href="http://xircles.codehaus.org/manage_email";> > http://xircles.codehaus.org/manage_email</a> > > > > -- > Adam Murdoch > Gradle Co-founder > http://www.gradle.org > VP of Engineering, Gradleware Inc. - Gradle Training, Support, Consulting > http://www.gradleware.com > >
