--
Luke Daley
Principal Engineer, Gradleware
http://gradleware.com
Forwarded message:

From: GitHub <[email protected]>
To: [email protected]
Subject: [gradle-scm] [gradle/gradle] 1bf410: generalized CodeNarc plugin

Branch: refs/heads/master
Home:   https://github.com/gradle/gradle
Commit: 1bf410a016afb1764cbb02901608dbcdadf3e1a6
https://github.com/gradle/gradle/commit/1bf410a016afb1764cbb02901608dbcdadf3e1a6
Author: Peter Niederwieser <[email protected]>
Date:   2012-01-23 (Mon, 23 Jan 2012)

Changed paths:
M subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CheckstylePlugin.groovy M subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CodeNarcPlugin.groovy M subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/CodeQualityExtension.groovy M subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/FindBugsPlugin.groovy M subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/JDependPlugin.groovy M subprojects/code-quality/src/main/groovy/org/gradle/api/plugins/quality/PmdPlugin.groovy M subprojects/code-quality/src/test/groovy/org/gradle/api/plugins/quality/CodeNarcPluginTest.groovy

Log Message:
-----------
generalized CodeNarc plugin

- only applies reporting-base instead of groovy-base plugin
- also configures tasks not added by the plugin (as good as it can)

Note: If this is to stay, similar changes should be made to all other code quality plugins. Besides, it might be worthwile to make the plugins add a 'codeQuality' lifecycle task.

I wonder if a more generic “analyze” task would be better.

Reply via email to