On 15/11/2012, at 10:35 PM, Luke Daley wrote:

> 
> On 15/11/2012, at 6:32 AM, Adam Murdoch wrote:
> 
>> 
>> On 15/11/2012, at 10:06 AM, Marcin Erdmann wrote:
>> 
>>> Hi all, 
>>> 
>>> I've started working on some stuff based around the design spec 
>>> @https://github.com/gradle/gradle/blob/master/design-docs/reporting.md 
>> 
>> Excellent.
>> 
>>> and have a few questions that don't seem to be covered in the spec. 
>>> 
>>> You can have a look at the code I managed to produce in my fork in 
>>> reporting-improvements branch 
>>> (https://github.com/erdi/gradle/tree/reporting-improvements). Basically 
>>> it's just a sketch of the task with only inputs and outputs specified and 
>>> without any implementation. The plan was to see how far I could get without 
>>> any major conceptual problems. Obviously I plan to add tests to it when 
>>> I'll find the answers to my questions. 
>>> 
>>> The following are the problems/questions I have: 
>>> 
>>> - Test task doesn't implement reporting so it won't be picked up by the 
>>> plugin when collecting all the reports to be put in the build dashboard 
>> 
>> I forgot to put that in as a story. We'd need to either:
>> 
>> * Change Test to implement Reporting, or
>> * Split out a separate TestReport task that implements Reporting, or
>> * Have GenerateBuildDashboard task know about Test task type.
>> 
>>> 
>>> - given the fact that GenerateBuildDashboard task should take a set of 
>>> Report instances as input (as per design doc) it is impossible to generate 
>>> any useful information in the build dashboard report about the reports 
>>> apart from the name (which is usually html, xml or text) and path. It is 
>>> impossible to link a report to a task that has generated the report.
>> 
>> Why do you want to link a report to a task? To get a better name for the 
>> report? Or something else?
> 
> The viewer needs to understand what the report is. How else are you going to 
> differentiate between the “test” and “integTest” reports?

Right. But that doesn't necessarily need to be the task name. It just needs to 
be some human consumable name and/or description for the report, and it might 
be better to ask the report this question, rather than ask the task that 
generated the report.

There may not be a task involved for a given report. For example, the dashboard 
will need to deal with the profile report, which is not generated by any task.

A better solution might be to add something like a 'displayName' property to 
Report.


--
Adam Murdoch
Gradle Co-founder
http://www.gradle.org
VP of Engineering, Gradleware Inc. - Gradle Training, Support, Consulting
http://www.gradleware.com

Reply via email to