On 13/03/13 00:36, Daz DeBoer wrote:
Hi Marcin
You pull request has been merged with a few tweaks. The most important
of those was to fix DefaultTaskGraphExecuter so that it is considered
"populated" whenever a task has been added. Without this fix 'gradle
--dry-run' was broken. This breakage was picked up by
TaskExecutionIntegrationTest, which I converted to Spock and added a
few "mustRunAfter" test cases.
Apart from running core:check before submitting the pull request I
probably should have run integTest:check as well. Sorry about that.
Other than that, it looks great. Get this into the user guide and I'm
sure it will be a popular feature.
One minor improvement would be to support the map-based syntax for
mustRunAfter, in a similar way to dependsOn:
task foo(mustRunAfter: 'bar')
Not sure what our plans around supporting different parameters in this
way, but it feels like a natural fit.
My intention was to make the DSL for mustRunAfter exactly the same as
for dependsOn. I thought that I achieved that by defining methods with
matching signatures on Task but apparently I was wrong. Now I see that
this syntax is handled in TaskFactory and the value is redirected via
Task's dependsOn(Object... paths) method. Will put a fix for that
together with some docs improvements on task ordering in the next pull
request.
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
