Ok, thank you. I opened the pull request (https://github.com/gradle/gradle/pull/149). I would be glad if somebody has the time to verify it.

Greetings

Martin


On 24.04.2013 14:32, Luke Daley wrote:
Hi Martin,

On 23/04/2013, at 10:17 PM, Martin Stockhammer <m.stockham...@web.de> wrote:

Hello,

I have a little patch that enhances the securityRole definition
of the ear plugin (see 
http://forums.gradle.org/gradle/topics/ear_deployment_descriptor_and_security_role)
How can I contribute this code? It is commited to a github fork and I
may create a pull request.

Yes, that's the process.

Are there special requirements for contributing patches?


 From a legal perspective, we are currently in the process of setting up a 
contributor license agreement. We will contact you retrospectively about this 
if your code makes it into the codebase.

Patches that have adequate documentation and test coverage will get applied 
much quicker. If you're unsure, send a pull request with what you have and ask 
for clarification/guidance in order to take it further.



---------------------------------------------------------------------
To unsubscribe from this list, please visit:

   http://xircles.codehaus.org/manage_email


Reply via email to