On 24 June 2013 09:42, Daz DeBoer <darrell.deb...@gradleware.com> wrote:
> On 24 June 2013 08:59, Luke Daley <luke.da...@gradleware.com> wrote: > >> >> On 24/06/2013, at 3:28 PM, Daz DeBoer <darrell.deb...@gradleware.com> >> wrote: >> >> > On 24 June 2013 07:51, Luke Daley <luke.da...@gradleware.com> wrote: >> > >> > On 24/06/2013, at 2:44 PM, Daz DeBoer <darrell.deb...@gradleware.com> >> wrote: >> > >> > > On 24 June 2013 05:32, Luke Daley <luke.da...@gradleware.com> wrote: >> > > >> https://github.com/gradle/gradle/blob/master/CONTRIBUTING.md#creating-commits-and-writing-commit-messages >> > > >> > > Git commit messages are expected (not required) to have a certain >> format, that tooling uses: >> https://github.com/phonegap/phonegap/wiki/Git-Commit-Message-Format >> > > >> > > Our recommendation is in tension with this. Can I update our >> recommendation to match the standard? >> > > >> > > What sort of tooling uses this? This isn't a 'standard' (de-facto or >> otherwise) that I was aware of. I don't mind changing but I'm curious about >> how widespread this is. >> > >> > Three that I know of that I use; GitHub, git log and IDEA. >> > >> > I'm wary of this turning into a 'colour of the bikeshed' argument, but >> my understanding is that these tools only assume a single title line >> followed by any number of detail lines. >> > >> > That said, I'm happy for the team to adopt and promote a common >> standard for commit messages, and I think adopting a commonly promoted >> format is a good idea. >> >> My vote is for the short (~50 chars) summary line, followed by blank >> line, followed by N number of detail paragraphs. That works well for >> tooling. I don't think it's worth specifying anything over that.\\ >> > > Fair enough. I've never found any tooling that benefits from the blank > line, but I guess it can't hurt. The discipline of coming up with a 50 > character summary is probably a good thing. > Of course what I mean is that i've never found any tooling that behaves badly without the blank line. -- Darrell (Daz) DeBoer Principal Engineer, Gradleware http://www.gradleware.com
