>My opinion is that we should put the fix in 1.7. While the root cause is
not a regression, it's a problem due to another change that is in 1.7.

+1

Thanks Luke for fixing it.


On Fri, Jul 12, 2013 at 7:50 PM, Luke Daley <luke.da...@gradleware.com>wrote:

> Hi,
>
> I've pushed a fix for http://issues.gradle.org/browse/GRADLE-2836 to the
> release branch. The problem was that the class generator was not thread
> safe. We need to decide if we do want this fix in 1.7 or not.
>
> It's technically not a regression. The bug has always been there. Due to
> another change in 1.7 though, it's now far more likely to bite. This is
> because we are now decorating FileCopyDetails, and this doesn't happen
> until execution time.
>
> The chance of this happening is kind of low, though we do have test cases
> that have consistently hit it. That's unlikely to happen in larger builds
> though.
>
> My opinion is that we should put the fix in 1.7. While the root cause is
> not a regression, it's a problem due to another change that is in 1.7.
>
> --
> Luke Daley
> Principal Engineer, Gradleware
> http://gradleware.com
>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>     http://xircles.codehaus.org/manage_email
>
>
>


-- 
Szczepan Faber
Principal engineer@gradleware; Lead@mockito

Reply via email to