On 17 Apr 2014, at 6:36 am, Radim Kubacki <radim.kuba...@gradleware.com> wrote:

> 
> 
> 
> On Wed, Apr 16, 2014 at 12:45 AM, Adam Murdoch <adam.murd...@gradleware.com> 
> wrote:
> 
> On 11 Apr 2014, at 6:55 am, Radim Kubacki <radim.kuba...@gradleware.com> 
> wrote:
> 
>> Hi,
>> 
>> one thing that is missing task selector implementation in toolingApi for 
>> 1.12 is the ability to run build and tell it to build selectors from 
>> different projects. Here is my idea how to fix this:
>> 
>> add StartParameter.{get|set}TaskParameters() where TaskParameter has same 
>> methods as existing LaunchableImplementation: 
>> 
>> @Incubating interface TaskParameter {
>>   String getTaskName(); 
>>   @Nullable String getProjectPath();
>> }
>> 
>> Then I can add another BuildConfigurationAction to expand these objects into 
>> list of tasks using existing o.g.execution.TaskSelector.
>> 
>> Also I will be able to get rid of StartParameter.projectPath property that 
>> is used now by current selector build.
> 
> Question: StartParameter.[gs]etProjectPath are marked @Incubating. Should I 
> remove them and add a notice to release notes.

Yes.

> Or do we want to keep them?
>> 
>> I am not sure about adding org.gradle.TaskParameter but I need to expose it 
>> somewhere if it becomes used by StartParameter. Also perhaps 
>> LaunchableParameter is better name. Is that OK or should I look for a 
>> different solution?
> 
> It looks fine to me.
> 
> I’d probably give the new type a name that reflects that it is a request or 
> criteria to use to select some tasks to run.
> 
> Will think about something better. 
> 
> 
> --
> Adam Murdoch
> Gradle Co-founder
> http://www.gradle.org
> VP of Engineering, Gradleware Inc. - Gradle Training, Support, Consulting
> http://www.gradleware.com
> 
> Join us for Gradle Summit 2014, June 12th and 13th in Santa Clara, CA: 
> http://www.gradlesummit.com
> 
> 


--
Adam Murdoch
Gradle Co-founder
http://www.gradle.org
VP of Engineering, Gradleware Inc. - Gradle Training, Support, Consulting
http://www.gradleware.com

Join us for Gradle Summit 2014, June 12th and 13th in Santa Clara, CA: 
http://www.gradlesummit.com

Reply via email to