[ https://issues.apache.org/jira/browse/GRIFFIN-232?focusedWorklogId=208773&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-208773 ]
ASF GitHub Bot logged work on GRIFFIN-232: ------------------------------------------ Author: ASF GitHub Bot Created on: 06/Mar/19 12:43 Start Date: 06/Mar/19 12:43 Worklog Time Spent: 10m Work Description: aborgatin commented on pull request #484: GRIFFIN-232 - add support pluggable predicates URL: https://github.com/apache/griffin/pull/484#discussion_r262923746 ########## File path: service/src/main/java/org/apache/griffin/core/job/SparkSubmitJob.java ########## @@ -185,17 +185,13 @@ private void setPredicates(String json) throws IOException { if (StringUtils.isEmpty(json)) { return; } - List<Map<String, Object>> maps = toEntity(json, - new TypeReference<List<Map>>() { + List<SegmentPredicate> predicates = toEntity(json, Review comment: Yes, this code is covered in tests. I add yet another. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 208773) Time Spent: 20m (was: 10m) > Implement pluggable Predicators in PredicatorFactory > ---------------------------------------------------- > > Key: GRIFFIN-232 > URL: https://issues.apache.org/jira/browse/GRIFFIN-232 > Project: Griffin (Incubating) > Issue Type: Improvement > Reporter: Aleksandr Borgatin > Priority: Minor > Time Spent: 20m > Remaining Estimate: 0h > > I propose add second type of predicate after "file.exist" - "custom". JSON > example for creation "custom" predicate > {code:java} > { > "type": "custom", > "config": { > "class": > "org.apache.griffin.core.job.FileExistPredicator", > "root.path": "/path/to/", > "path": "file.ext,file2.txt" > } > } > {code} > Proposed contract for implementations is based on FileExistPredicator: > * class must implement interface *org.apache.griffin.core.job.Predicator* > * class must have constructor with argument of type > *org.apache.griffin.core.job.entity.SegmentPredicate* -- This message was sent by Atlassian JIRA (v7.6.3#76005)