[ https://issues.apache.org/jira/browse/GRIFFIN-237?focusedWorklogId=213633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213633 ]
ASF GitHub Bot logged work on GRIFFIN-237: ------------------------------------------ Author: ASF GitHub Bot Created on: 15/Mar/19 08:46 Start Date: 15/Mar/19 08:46 Worklog Time Spent: 10m Work Description: dershovGD commented on pull request #486: GRIFFIN-237 Implement service method get JobInstanceBean by id URL: https://github.com/apache/griffin/pull/486#discussion_r265890642 ########## File path: service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ########## @@ -288,6 +288,11 @@ public void deleteJob(String name) throws SchedulerException { return updateState(instances); } + @Override + public JobInstanceBean findInstance(Long id) { + return instanceRepo.findByInstanceId(id); + } Review comment: I think, it will return null or an exception without any information, what exactly happens. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 213633) Time Spent: 1h (was: 50m) > [Jobs] Implement service method getting JobInstanceBean by JobInstanceBean id > ----------------------------------------------------------------------------- > > Key: GRIFFIN-237 > URL: https://issues.apache.org/jira/browse/GRIFFIN-237 > Project: Griffin (Incubating) > Issue Type: New Feature > Reporter: Dmitry Ershov > Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > Getting particular entity by id is very natural part of any API.Together with > GRIFFIN-229 it would allow to wait for job > completion, unlocking lots of potential use cases. > > h2. Server > Provide a RESTful GET method to _/api/v1//jobs/instances/\{jobInstanceId}_ > returning JobInstanceBean for specified jobInstanceBean id. -- This message was sent by Atlassian JIRA (v7.6.3#76005)