chemikadze commented on a change in pull request #489: GRIFFIN-240 Return
JobInstanceBean in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r266699462
##########
File path: service/src/main/java/org/apache/griffin/core/job/JobInstance.java
##########
@@ -281,7 +286,8 @@ private void createJobInstance(Map<String, Object> confMap)
throw new GriffinException.ConflictException
(QUARTZ_JOB_ALREADY_EXIST);
}
- saveJobInstance(jobName, groupName);
+ String triggerName = (String) confMap.get(TRIGGER_KEY);
Review comment:
why trigger _key_ is named on bean object as trigger _name_?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
