[
https://issues.apache.org/jira/browse/GRIFFIN-240?focusedWorklogId=215157&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215157
]
ASF GitHub Bot logged work on GRIFFIN-240:
------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/19 01:14
Start Date: 19/Mar/19 01:14
Worklog Time Spent: 10m
Work Description: chemikadze commented on pull request #489: GRIFFIN-240
Return JobInstanceBean in response to a call Trigger job by id
URL: https://github.com/apache/griffin/pull/489#discussion_r266699321
##########
File path: service/src/main/java/org/apache/griffin/core/job/JobController.java
##########
@@ -115,8 +120,19 @@ public JobHealth getHealthInfo() {
}
@RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
- @ResponseStatus(HttpStatus.NO_CONTENT)
- public void triggerJob(@PathVariable("id") Long id) throws
SchedulerException {
- jobService.triggerJobById(id);
+ @ResponseStatus(HttpStatus.OK)
+ public JobInstanceBean triggerJob(@PathVariable("id") Long id,
@RequestBody(required = false) String request) throws SchedulerException {
+ return jobService.triggerJobById(id, extractTimeOut(request));
+ }
+
+ private long extractTimeOut(String request) {
Review comment:
this timeout is rather infra concern, than of particular request, and 99% of
all usages won't care about exact value -- let have it as configuration
property, not a request body parameter
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 215157)
> [Service] Return JobInstance in response to a call Trigger job by id
> ---------------------------------------------------------------------
>
> Key: GRIFFIN-240
> URL: https://issues.apache.org/jira/browse/GRIFFIN-240
> Project: Griffin (Incubating)
> Issue Type: Improvement
> Reporter: Aleksandr Borgatin
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The proposal is following: in response of method "/jobs/trigger/\{id}" to
> return JobInstance
> {code:java}
> @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
> @ResponseStatus(HttpStatus.OK)
> public JobInstanceBean triggerJob(@PathVariable("id") Long id) throws
> SchedulerException
> { return jobService.triggerJobById(id); }{code}
> Now this method looks like this
> {code:java}
> @RequestMapping(value = "/jobs/trigger/{id}", method = RequestMethod.POST)
> @ResponseStatus(HttpStatus.NO_CONTENT)
> public void triggerJob(@PathVariable("id") Long id) throws
> SchedulerException {
> jobService.triggerJobById(id);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
