toyboxman commented on a change in pull request #514: [GRIFFIN-269] Griffin submit job to livy server with Kerberos Authentication URL: https://github.com/apache/griffin/pull/514#discussion_r306222937
########## File path: service/src/main/java/org/apache/griffin/core/job/SparkSubmitJob.java ########## @@ -19,55 +19,40 @@ Licensed to the Apache Software Foundation (ASF) under one package org.apache.griffin.core.job; -import static org.apache.griffin.core.config.EnvConfig.ENV_BATCH; -import static org.apache.griffin.core.config.EnvConfig.ENV_STREAMING; -import static org.apache.griffin.core.config.PropertiesConfig.livyConfMap; -import static org.apache.griffin.core.job.JobInstance.JOB_NAME; -import static org.apache.griffin.core.job.JobInstance.MEASURE_KEY; -import static org.apache.griffin.core.job.JobInstance.PREDICATES_KEY; -import static org.apache.griffin.core.job.JobInstance.PREDICATE_JOB_NAME; -import static org.apache.griffin.core.job.entity.LivySessionStates.State; -import static org.apache.griffin.core.job.entity.LivySessionStates.State.FOUND; -import static org.apache.griffin.core.job.entity.LivySessionStates.State.NOT_FOUND; -import static org.apache.griffin.core.measure.entity.GriffinMeasure.ProcessType.BATCH; -import static org.apache.griffin.core.util.JsonUtil.toEntity; import com.fasterxml.jackson.core.type.TypeReference; - -import java.io.IOException; -import java.util.ArrayList; -import java.util.HashMap; -import java.util.List; -import java.util.Map; - import org.apache.griffin.core.job.entity.JobInstanceBean; import org.apache.griffin.core.job.entity.SegmentPredicate; import org.apache.griffin.core.job.factory.PredicatorFactory; import org.apache.griffin.core.job.repo.JobInstanceRepo; import org.apache.griffin.core.measure.entity.GriffinMeasure; import org.apache.griffin.core.measure.entity.GriffinMeasure.ProcessType; import org.apache.griffin.core.util.JsonUtil; -import org.quartz.DisallowConcurrentExecution; -import org.quartz.Job; -import org.quartz.JobDetail; -import org.quartz.JobExecutionContext; -import org.quartz.PersistJobDataAfterExecution; -import org.quartz.SchedulerException; -import org.quartz.SimpleTrigger; +import org.quartz.*; Review comment: please use explicit import instead of asterisk FYI https://github.com/apache/griffin/blob/master/griffin-doc/dev/code-style.md ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
