toyboxman commented on code in PR #658: URL: https://github.com/apache/griffin/pull/658#discussion_r1688005810
########## griffin-metric/pom.xml: ########## @@ -17,24 +17,23 @@ KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> -<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; -xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> - +<project xmlns="http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <modelVersion>4.0.0</modelVersion> <parent> - <groupId>org.apache</groupId> - <artifactId>apache</artifactId> - <version>17</version> - <relativePath /> + <groupId>org.apache.griffin</groupId> + <artifactId>griffin</artifactId> + <version>2.0.0-SNAPSHOT</version> </parent> - <groupId>org.apache.griffin</groupId> + <groupId>org.apache.griffin.metric</groupId> Review Comment: @whhe , Now we are dividing the whole package into 4 individuals. those below are separated libs to offer. By @guoyuepeng new architecture, we should split the them. If you have any concern, let us know. [INFO] griffin-connectors-2.0.0-SNAPSHOT .................. SUCCESS [ 0.082 s] [INFO] griffin-metric-2.0.0-SNAPSHOT ...................... SUCCESS [ 0.055 s] [INFO] griffin-dqc-2.0.0-SNAPSHOT ......................... SUCCESS [ 0.041 s] [INFO] griffin-schedulers-2.0.0-SNAPSHOT .................. SUCCESS [ 0.046 s] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
