guoyuepeng commented on code in PR #673: URL: https://github.com/apache/griffin/pull/673#discussion_r1900505815
########## griffin-metric/src/main/java/org/apache/griffin/metric/entity/MetricV.java: ########## @@ -44,14 +46,22 @@ Licensed to the Apache Software Foundation (ASF) under one public class MetricV extends BaseEntity { /** - * An unique identity for a metric. + * An incremental identity in metric value table. */ - @TableId(value="mid", type = IdType.AUTO) + @TableId(value="vid", type = IdType.AUTO) Review Comment: this looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@griffin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org