Github user whhe commented on the issue:

    https://github.com/apache/incubator-griffin/pull/332
  
    Hi @toyboxman 
    
    I understand your concern and I agree that %n is better than \n as line 
separator. As you mentioned, the change you committed is acceptable, but not 
necessary in this situation.
    
    If you insist on changing it, the lines below will be put into the same 
request body, so we should keep them consistent in structure. 
    
https://github.com/apache/incubator-griffin/blob/37b5cbbe10c7e7c26176a4cfafdceba5ef17e3b1/service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java#L84
    
https://github.com/apache/incubator-griffin/blob/37b5cbbe10c7e7c26176a4cfafdceba5ef17e3b1/service/src/main/java/org/apache/griffin/core/metric/MetricStoreImpl.java#L146
    
    And I'm not sure if there is more \n that can be modified, you'b better 
change them together.


---

Reply via email to