[ 
https://issues.apache.org/jira/browse/GRIFFIN-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624337#comment-16624337
 ] 

Nikolay Sokolov edited comment on GRIFFIN-198 at 9/21/18 11:53 PM:
-------------------------------------------------------------------

Prepared fix and tests for first item: 
https://github.com/apache/incubator-griffin/pull/419

However, fix for second option is questionable:
* retries can be added inside getTables(String)
* instead of incomplete results, it can return empty/null result

Another question is, shouldn't API calls return 5xx instead of 200 with empty 
data in these cases?
I did not do anything which changes current behavior drastically, waiting for 
community to respond.


was (Author: chemikadze):
Prepared fix and tests for first item: 
https://github.com/apache/incubator-griffin/pull/419

However, fix for second option is questionable:
* retries can be added inside getTables(String)
* instead of incomplete results, it can return empty/null result

Another question is, shouldn't API calls return 5xx instead of 200 with empty 
data in these cases?

> HiveMetaStoreServiceImpl caches incorrect state of metastore
> ------------------------------------------------------------
>
>                 Key: GRIFFIN-198
>                 URL: https://issues.apache.org/jira/browse/GRIFFIN-198
>             Project: Griffin (Incubating)
>          Issue Type: Bug
>            Reporter: Nikolay Sokolov
>            Priority: Major
>
> Currently, HiveMetaStoreServiceImpl is caching:
> * nulls and empty lists in some methods, when metastore request failed for 
> some reason
> * empty list of tables as response to getAllTable(String) and getAllTable() 
> calls
> Both problems result in confusing output on large amount of tables.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to