Github user toyboxman commented on a diff in the pull request:

    https://github.com/apache/incubator-griffin/pull/441#discussion_r226903865
  
    --- Diff: 
service/src/main/java/org/apache/griffin/core/login/ldap/SelfSignedSocketFactory.java
 ---
    @@ -0,0 +1,68 @@
    +package org.apache.griffin.core.login.ldap;
    +
    +import javax.net.SocketFactory;
    +import javax.net.ssl.SSLContext;
    +import javax.net.ssl.SSLSocketFactory;
    +import javax.net.ssl.TrustManager;
    +import javax.net.ssl.X509TrustManager;
    +import java.io.IOException;
    +import java.net.InetAddress;
    +import java.net.Socket;
    +import java.net.UnknownHostException;
    +import java.security.cert.CertificateException;
    +import java.security.cert.X509Certificate;
    +
    +public class SelfSignedSocketFactory extends SocketFactory {
    --- End diff --
    
    as a public class, you have to add java doc to describe


---

Reply via email to