Github user chemikadze commented on a diff in the pull request: https://github.com/apache/incubator-griffin/pull/442#discussion_r227217198 --- Diff: service/src/main/java/org/apache/griffin/core/measure/entity/Rule.java --- @@ -81,6 +81,9 @@ Licensed to the Apache Software Foundation (ASF) under one @Column(name = "\"out\"") private String out; + @JsonInclude(JsonInclude.Include.NON_NULL) --- End diff -- @toyboxman don't see anything, service/api-guide.md does not describe any style guides or standard contracts, only shows examples. Also "cache" field was not documented in measure-configuration-guide.md, added information about it there. Javadoc says: ``` * @param cache cache the result for multiple usage (optional, valid for "spark-sql" and "df-ops" mode) ``` Taking into account it's valid not for all types of rules, hiding null values seems to be only valid behavior.
---