[GitHub] incubator-griffin pull request #444: Define griffin plain-vanilla hook.

[chemikadze]

Github user chemikadze commented on a diff in the pull request:

    https://github.com/apache/incubator-griffin/pull/444#discussion_r227900111
  
    --- Diff: 
service/src/main/java/org/apache/griffin/core/job/JobServiceImpl.java ---
    @@ -128,10 +129,22 @@ Licensed to the Apache Software Foundation (ASF) 
under one
         @Autowired
         private StreamingJobOperatorImpl streamingJobOp;
     
    +    @Value("${internal.event.listeners}")
    --- End diff --
    
    Probably it should go to separate `@Configuration`, parametrized by 
`@Value` and providing `@Bean List<GriffinHook>` or some `@Bean 
GriffinHookExecutor`. All integration points (JobService, MeasureService) would 
have this bean autowired.


---