[
https://issues.apache.org/jira/browse/GRIFFIN-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664516#comment-16664516
]
ASF GitHub Bot commented on GRIFFIN-208:
----------------------------------------
Github user chemikadze commented on a diff in the pull request:
https://github.com/apache/incubator-griffin/pull/448#discussion_r228385053
--- Diff:
measure/src/main/scala/org/apache/griffin/measure/Application.scala ---
@@ -104,12 +106,18 @@ object Application extends Loggable {
case Success(_) =>
info("process end success")
case Failure(ex) =>
- error(s"process end error: ${ex.getMessage}")
+ error(s"process end error: ${ex.getMessage}", ex)
shutdown
sys.exit(-5)
}
shutdown
+
+ if (success) {
--- End diff --
looks like this one breaks a lot of stuff
> Job status is SUCCESS even if some stages have failed
> -----------------------------------------------------
>
> Key: GRIFFIN-208
> URL: https://issues.apache.org/jira/browse/GRIFFIN-208
> Project: Griffin (Incubating)
> Issue Type: Bug
> Reporter: Nikolay Sokolov
> Priority: Major
>
> When some steps (MetricWrite or SparkSql, for example) fail, errors are just
> logged, but not reported as part of job status. Symptoms:
> {code:none}
> 18/10/22 17:17:58 ERROR transform.SparkSqlTransformStep: run spark sql [ ....
> ] error: ...
> {code}
> YarnApplicationState: FINISHED
> FinalStatus Reported by AM: SUCCEEDED
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
