Github user toyboxman commented on a diff in the pull request:

    https://github.com/apache/incubator-griffin/pull/444#discussion_r230046728
  
    --- Diff: 
service/src/main/java/org/apache/griffin/core/integration/JobEventHook.java ---
    @@ -0,0 +1,11 @@
    +package org.apache.griffin.core.integration;
    +
    +import org.apache.griffin.core.exception.GriffinException;
    +
    +public class JobEventHook implements GriffinHook {
    +    @Override
    +    public void onEvent(GriffinEvent event) throws GriffinException {
    +        throw new GriffinException.UnImplementedException(
    +            "This method needs to be reimplemented by event-consuming 
purpose");
    --- End diff --
    
    if we think about exporting interface and hope user to implement method 
details. we should let it empty or throw a exception tip here


---

Reply via email to