So the current status is that the extension module jars used for tests are now built at compile time. So there's no need for the jars in source anymore. The only jar left is GroovyJarTest.jar, which doesn't contain any binary (just Groovy scripts). The fun thing is that the test is broken. First of all, it's not executed at all, because security tests are disabled (it should have been a temporary disabling, but it's getting complicated). Second, even if you execute the test, it doesn't take long, looking at the contents of the scripts in the jar, that they are not executed. In short, it is IMHO safe to remove, and the test should be rewritten.
2015-06-16 9:16 GMT+02:00 Bertrand Delacretaz <[email protected]>: > On Mon, Jun 15, 2015 at 11:00 PM, Emmanuel Lécharny <[email protected]> > wrote: > > ...The ideal situation would be to create those jars in teh process, > before > > using them in a test... > > Yes, that's by far the best way - create them from (readable, usual) > source code. > > Second best IMO is to have them in a separate folder with a README > that explains what they are and lists their sha1 digests so to help > reassure people that they are legit. > > -Bertrand >
