Thanks everyone! I'm happy to be on board. BTW, I think it's still a good idea to use PRs for a short period of time, > so that you can accommodate with our dev process. In particular, how > patches should be applied on master and cherry picked on maintenance > branches.
I committed a small change to master and cherry picked it to 2_4_X yesterday, hope that was ok. I'll continue using PRs going forward for the time being. As far as merging pull requests, I read through a few of the dev threads from when Groovy migrated to Apache, but couldn't find a definitive workflow. Is that documented anywhere? If not, I can write it as I get familiar. BTW: I prefer a model where committers are also supposed to go through > pull request / review processes. I believe that does not decrease > productivity, but has a range of beneficial effects. Becoming a > committer should ideally just mean the ability to approve and merge > other people's pull requests/patches. I find this beneficial as well, for code changes. It's a useful way to keep up with the codebase, rather than just browsing commits. Shil On Tue, Oct 20, 2015 at 3:20 PM, Guillaume Laforge <[email protected]> wrote: > Welcome Shils! > > On Tue, Oct 20, 2015 at 6:58 PM, Pascal Schumacher < > [email protected]> wrote: > >> The IncubatingProject Management Committee (IPMC) for Apache >> Groovy Incubatinghas asked Shil Sinhato become a committer and we >> are pleased to announce that they have accepted. >> >> During the past six months Shils contributed 14 pull request the Groovy >> project [1]. Most of the pull request fixed bugs in difficult areas of >> the Groovy codebase. Every bugfix was accompanied by one or more test. >> >> Shils also contributed constructively to the discussion of issues in the >> Groovy bugtracker [2]. >> >> [1]https://github.com/apache/incubator-groovy/commits/master?author=shils >> [2]https://issues.apache.org/jira/secure/ViewProfile.jspa?name=shils >> >> Being a committer enables easier contribution to the project >> since there is no need to go via the patch / pull >> requestsubmission process. This should enable better productivity. >> >> > > > -- > Guillaume Laforge > Apache Groovy committer & PMC member > Product Ninja & Advocate at Restlet <http://restlet.com> > > Blog: http://glaforge.appspot.com/ > Social: @glaforge <http://twitter.com/glaforge> / Google+ > <https://plus.google.com/u/0/114130972232398734985/posts> >
