Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/319#discussion_r220397742
  
    --- Diff: 
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/resources/org/apache/guacamole/auth/jdbc/connection/ConnectionRecordMapper.xml
 ---
    @@ -79,7 +79,10 @@
                 #{record.sharingProfileIdentifier,jdbcType=VARCHAR},
                 #{record.sharingProfileName,jdbcType=VARCHAR},
                 (SELECT user_id FROM guacamole_user
    -             WHERE username = #{record.username,jdbcType=VARCHAR}),
    +             JOIN guacamole_entity ON guacamole_user.entity_id = 
guacamole_entity.entity_id
    --- End diff --
    
    Seems like this code here expects that, when users are deleted from the 
database, their entries will remain present in the `guacamole_entity` table?  
Just want to confirm...


---

Reply via email to