Github user necouchman commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/351#discussion_r244544987
  
    --- Diff: guacamole-docker/bin/build-guacamole.sh ---
    @@ -126,3 +126,15 @@ if [ -f 
extensions/guacamole-auth-radius/target/guacamole-auth-radius*.jar ]; th
         mkdir -p "$DESTINATION/radius"
         cp extensions/guacamole-auth-radius/target/guacamole-auth-radius*.jar 
"$DESTINATION/radius"
     fi
    +
    +# Copy OPENID auth extension and schema modifications
    +#
    +
    +mkdir -p "$DESTINATION/openid"
    +tar -xzf extensions/guacamole-auth-openid/target/*.tar.gz \
    --- End diff --
    
    A couple of items, here:
    - Why not just use the jar file?  In the case of LDAP above, it is 
extracted because the LDIF file is also there.  For this module, though, just 
having the JAR should be sufficient.
    - All of the slashes at the end of the line should line up.


---

Reply via email to