Github user mike-jumper commented on a diff in the pull request:

    https://github.com/apache/guacamole-client/pull/353#discussion_r245779470
  
    --- Diff: 
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/connection/ConnectionService.java
 ---
    @@ -167,18 +201,34 @@
                                 // Parse name
                                 String name = parameter.substring(0, equals);
                                 String value = parameter.substring(equals+1);
    -
    -                            config.setParameter(name, value);
    +                            
    +                            // Pull out and set proxy parameters, if 
present
    +                            // Otherwise set the parameter.
    +                            switch(name) {
    +                                case PROXY_HOST_PARAMETER:
    --- End diff --
    
    We could switch over to the ASF one: 
https://cwiki.apache.org/confluence/display/DIRxPMGT/OID+Assignment+Scheme
    
    Probably a good idea to do so. I'll still locate the ancient scrap of paper 
to server as a reference for assigning numbers from that, though - we need to 
use some consistent method for assigning the numbers within the Guacamole part 
of the ASF space (once that exists).


---

Reply via email to