necouchman commented on a change in pull request #454: GUACAMOLE-793: CAS
Provider returns Group - like LDAP Provider
URL: https://github.com/apache/guacamole-client/pull/454#discussion_r361682358
##########
File path:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/ConfigurationService.java
##########
@@ -85,4 +85,40 @@ public PrivateKey getClearpassKey() throws
GuacamoleException {
return
environment.getProperty(CASGuacamoleProperties.CAS_CLEARPASS_KEY);
}
+ /**
+ * Returns the attribute used to determine group memberships
+ * in CAS, or null if not defined.
+ *
+ * @return
+ * The attribute name user to determine group memberships in CAS,
+ * null if not defined.
+ *
+ * @throws GuacamoleException
+ * If guacamole.properties cannot be parsed.
+ */
+ public String getCasGroupAttribute() throws GuacamoleException {
Review comment:
In sticking with the way the rest of these methods are named, I'd suggest
taking the "Cas" out of this and making it `getGroupAttribute()`, and similarly
with the method below for the group DN format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
