echu2013 commented on a change in pull request #496: GUACAMOLE-996: Add support
for configuring group filter.
URL: https://github.com/apache/guacamole-client/pull/496#discussion_r403524577
##########
File path:
extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/group/UserGroupService.java
##########
@@ -79,17 +79,17 @@
* @throws GuacamoleException
* If guacamole.properties cannot be parsed.
*/
- private ExprNode getGroupSearchFilter() throws GuacamoleException {
+ private ExprNode buildGroupSearchFilter() throws GuacamoleException {
Review comment:
I though it was more descriptive this name rather than get, also to avoid
confusion with
` return confService.getGroupSearchFilter();
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
