mike-jumper commented on a change in pull request #274:
URL: https://github.com/apache/guacamole-server/pull/274#discussion_r419657712
##########
File path: src/protocols/rdp/channels/rdpsnd/rdpsnd.c
##########
@@ -48,6 +52,10 @@ void guac_rdpsnd_process_receive(guac_rdp_common_svc* svc,
guac_rdpsnd_wave_handler(svc, input_stream, &header);
return;
}
+
+ /* Check body size */
+ if (Stream_GetRemainingLength(input_stream) < header.body_size)
Review comment:
Given the above, my thinking would be that it's not correct to check
against `header.body_size` here, but that each logical attempt to read/seek
through a block of data within `input_stream` should take it upon itself to
first verify that the necessary number of bytes are available before attempting
that read/seek.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
